Update defaults for extra values to support lists#522
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
jenkins test this please |
|
related to #530 |
|
jenkins test this please |
|
There was an issue with the initContainer check, so I merged in latest from master |
|
jenkins test this please |
|
Looking at the filebeat PR, would you suggest adding the same pattern - where if string use the old method if not parse the yaml? |
|
jenkins test this please |
jmlrt
left a comment
jmlrt
left a comment
There was a problem hiding this comment.
Thanks you for this PR 👍
- Default values should be updated in
README.mdforextraVolumes,extraVolumeMounts,extraContainersandextraInitContainers. - It would also be great if you could update the tests for this 4 values in https://github.com/elastic/helm-charts/blob/master/elasticsearch/tests/elasticsearch_test.py#L287-L341, similarly to what has been done in #530
|
I've updated with the requested changes now |
|
jenkins test this please |
jmlrt
left a comment
jmlrt
left a comment
There was a problem hiding this comment.
Some changes are required to make Black formatter happy in elastic+helm-charts+pull-request+lint-python/149. Hope this is the last change to do.
|
I think I've fixed the linting errors, the jenkins console log was hard to read honestly |
|
jenlins test this please |
Update defaults for extra values to support lists
|
backported to |
3 participants
Currently if you specify extraEnvs, extraVolumes or extraVolumeMounts it breaks the deployment. Updated so field looks for lists and not strings.